Content-Length: 359837 | pFad | http://github.com/temporalio/sdk-java/pull/2377/commits/41c20c0701da490099344bc1b034ae28ea08254c

F4 Docstring edits by dandavison · Pull Request #2377 · temporalio/sdk-java · GitHub
Skip to content

Docstring edits #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Docstring edits #2377

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af2f92b
Edits
dandavison Apr 22, 2024
1000926
edit
dandavison Aug 13, 2024
41c20c0
edits
dandavison Sep 3, 2024
38f675d
Edit
dandavison Jan 18, 2025
0e27126
edit
dandavison Jan 18, 2025
e9ad3a2
suggested change from review
dandavison Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
edits
  • Loading branch information
@dandavison
dandavison committed Jan 24, 2025
commit 41c20c0701da490099344bc1b034ae28ea08254c
8 changes: 4 additions & 4 deletions temporal-sdk/src/main/java/io/temporal/workflow/ActivityStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
import java.lang.reflect.Type;

/**
* ActivityStub is used to call an activity without referencing an interface it implements. This is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: An activity implementation can implement multiple interfaces so I think an is more correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, changed

* useful to call activities when their type is not known at compile time or to execute activities
* ActivityStub is used to call an activity without referencing the interface that it implements. This is
* useful for calling activities when their type is not known at compile time, or for executing activities
* implemented in other languages. Created through {@link Workflow#newActivityStub(Class)}.
*/
public interface ActivityStub {

/**
* Executes an activity by its type name and arguments. Blocks until the activity completion.
* Executes an activity by its type name and arguments. Blocks until activity completion.
*
* @param activityName name of an activity type to execute.
* @param resultClass the expected return type of the activity. Use Void.class for activities that
Expand All @@ -42,7 +42,7 @@ public interface ActivityStub {
<R> R execute(String activityName, Class<R> resultClass, Object... args);

/**
* Executes an activity by its type name and arguments. Blocks until the activity completion.
* Executes an activity by its type name and arguments. Blocks until activity completion.
*
* @param activityName name of an activity type to execute.
* @param resultClass the expected return class of the activity. Use Void.class for activities
Expand Down
4 changes: 2 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/workflow/Async.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public final class Async {

/**
* Invokes zero argument function asynchronously.
* Invokes a zero-argument function asynchronously.
*
* @param function Function to execute asynchronously
* @return promise that contains function result or failure
Expand All @@ -39,7 +39,7 @@ public static <R> Promise<R> function(Functions.Func<R> function) {
}

/**
* Invokes one argument function asynchronously.
* Invokes a one-argument function asynchronously.
*
* @param function Function to execute asynchronously
* @param arg1 first function argument
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/temporalio/sdk-java/pull/2377/commits/41c20c0701da490099344bc1b034ae28ea08254c

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy