-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency of future #7
Comments
It's been a while since I've looked at the codebase, but you're right it looks like pysignals just uses the range function one time. However, have you contacted the authors of the python-future project to determine when they plan to resolve the issue? It looks like this is a known issue and indeed there is even a PR to fix, at least one problem, with python 3.12: What environment are you working in? I can see in Fedora that python-future has been patched (from the PR in the previous link) and is building fine for that distro: |
You are right, we've managed (in Fedora) to patch the sources and also create a new Python package called zombie-imp which contains the imp module removed from the standard library to make the future package work with Python 3.12. However, the plan for 3.13 is to also remove lib2to3 from the standard library, which is I'd say the core of future and I'd rather remove the dependency on future in projects where it's possible and doesn't mean a lot of work rather than fix the old library. |
And it!s already removed: python/cpython#104780 |
Understood. Thank you for the explanation. I'll get this fixed in this upstream repo then build a new pysignals package in Fedora repos. |
Because we are using range in a For loop, it turns out this project didn't even need python-future at all. The native behavior of range in python 2 or 3 will work just fine. |
Hello. I see that the project depends on future. I can find only a single usage of it in the codebase.
PySignals/pysignals/dispatcher.py
Line 6 in 832b2c6
Do you think it's still useful? I'm asking because future is broken with the latest Python 3.12 and will be even more with 3.13 so it might be a good idea to get rid of it.
The text was updated successfully, but these errors were encountered: