Content-Length: 239741 | pFad | http://github.com/theojulienne/PySignals/issues/7

54 Dependency of future · Issue #7 · theojulienne/PySignals · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency of future #7

Closed
frenzymadness opened this issue Aug 29, 2023 · 5 comments
Closed

Dependency of future #7

frenzymadness opened this issue Aug 29, 2023 · 5 comments

Comments

@frenzymadness
Copy link

Hello. I see that the project depends on future. I can find only a single usage of it in the codebase.

from future.builtins import range

Do you think it's still useful? I'm asking because future is broken with the latest Python 3.12 and will be even more with 3.13 so it might be a good idea to get rid of it.

@knight-of-ni
Copy link
Collaborator

knight-of-ni commented Aug 29, 2023

It's been a while since I've looked at the codebase, but you're right it looks like pysignals just uses the range function one time.
I'm not opposed to rewriting this.

However, have you contacted the authors of the python-future project to determine when they plan to resolve the issue?

It looks like this is a known issue and indeed there is even a PR to fix, at least one problem, with python 3.12:
PythonCharmers/python-future#618

What environment are you working in?

I can see in Fedora that python-future has been patched (from the PR in the previous link) and is building fine for that distro:
https://src.fedoraproject.org/rpms/future/blob/rawhide/f/future.spec#_36

@frenzymadness
Copy link
Author

You are right, we've managed (in Fedora) to patch the sources and also create a new Python package called zombie-imp which contains the imp module removed from the standard library to make the future package work with Python 3.12. However, the plan for 3.13 is to also remove lib2to3 from the standard library, which is I'd say the core of future and I'd rather remove the dependency on future in projects where it's possible and doesn't mean a lot of work rather than fix the old library.
Moreover, many packages have future in the list of dependencies even if they do not use it at all or they use one little thing from it and it's simple to rewrite even without dropping Python 2 support.

@frenzymadness
Copy link
Author

And it!s already removed: python/cpython#104780

@knight-of-ni
Copy link
Collaborator

Understood. Thank you for the explanation.

I'll get this fixed in this upstream repo then build a new pysignals package in Fedora repos.

@knight-of-ni
Copy link
Collaborator

knight-of-ni commented Aug 29, 2023

Because we are using range in a For loop, it turns out this project didn't even need python-future at all. The native behavior of range in python 2 or 3 will work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/theojulienne/PySignals/issues/7

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy