Content-Length: 310826 | pFad | http://github.com/typescript-eslint/typescript-eslint/issues/11351

1CA fix(eslint-plugin): [consistent-generic-constructors] resolve conflict with `isolatedDeclarations` if enabled in `constructor` option by nayounsang · Pull Request #11351 · typescript-eslint/typescript-eslint · GitHub
Skip to content

fix(eslint-plugin): [consistent-generic-constructors] resolve conflict with isolatedDeclarations if enabled in constructor option #11351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [consistent-generic-constructors] resolve conflict with isolatedDeclarations if enabled in constructor option #11351

wants to merge 3 commits into from
+12 −1

Conversation

nayounsang
Copy link
Contributor

PR Checklist

Overview

  • Ignore report when isolatedDeclarations is enabled in constructor option.
  • add tc

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 27, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cde85be
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685eb02917924e000814bc19
😎 Deploy Preview https://deploy-preview-11351--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit cde85be.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 4s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 10s View ↗
nx run-many -t lint ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-27 15:03:40 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (db32b8a) to head (cde85be).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11351   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50919    50920    +1     
  Branches     8387     8387           
=======================================
+ Hits        46256    46257    +1     
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts 97.10% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [consistent-generic-constructors] Don't conflict with isolatedDeclarations if enabled
1 participant
@nayounsang








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/issues/11351

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy