Merge pull request #12 from sparkdevio/remove-flip

Prosper Otemuyiwa · web-flow · commit abc0db31f7fd · 2017-04-26T04:27:46.000+01:00
Remove the flip altogether
diff --git a/src/DumbPasswordServiceProvider.php b/src/DumbPasswordServiceProvider.php
@@ -29,11 +29,10 @@ class DumbPasswordServiceProvider extends ServiceProvider
     public function boot()
     {
         $path = realpath(__DIR__.'/../resources/config/passwordlist.txt');
-        $dumbPasswords = collect(explode("\n", file_get_contents($path)));
-        $data = $dumbPasswords->flip();
+        $data = collect(explode("\n", file_get_contents($path)));
 
         Validator::extend('dumbpwd', function ($attribute, $value, $parameters, $validator) use ($data) {
-            return !$data->has($value);
+            return !$data->contains($value);
         }, $this->message);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -29,11 +29,10 @@ class DumbPasswordServiceProvider extends ServiceProvider`
`29`	`29`	`public function boot()`
`30`	`30`	`{`
`31`	`31`	`$path = realpath(__DIR__.'/../resources/config/passwordlist.txt');`
`32`		`- $dumbPasswords = collect(explode("\n", file_get_contents($path)));`
`33`		`- $data = $dumbPasswords->flip();`
	`32`	`+ $data = collect(explode("\n", file_get_contents($path)));`
`34`	`33`
`35`	`34`	`Validator::extend('dumbpwd', function ($attribute, $value, $parameters, $validator) use ($data) {`
`36`		`- return !$data->has($value);`
	`35`	`+ return !$data->contains($value);`
`37`	`36`	`}, $this->message);`
`38`	`37`	`}`
`39`	`38`