UserSelectQueryBuilder::named returns non-named users
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Thu, Jan 2, 2:29 PM

Description

UserSelectQueryBuilder has a named() filter to ensure only named users are returned. Unfortunately, it seems to have a bug. The following code:

var_dump(
	$this->getServiceContainer()->getUserIdentityLookup()
		->newSelectQueryBuilder()
		->named()
		->fetchUserNames()
);

returns the following on my system:

[...]
  string(14) "147.32.219.118"
  [57]=>
  string(10) "172.19.0.1"
  [58]=>
  string(10) "172.26.0.1"
  [59]=>
  string(11) "192.168.0.1"
[...]

Those actors are certainly not named, but they are indeed not temporary.

Details

	Subject	Repo	Branch	Lines +/-
	UserSelectQueryBuilder: Do not consider unregistered actors to be named	mediawiki/core	master	+13 -5

Customize query in gerrit

Event Timeline

Urbanecm_WMF created this task.Thu, Jan 2, 2:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jan 2, 2:29 PM

This is happening, because User::isNamed and UserSelectQueryBuilder::named have very different implementations. While User::isNamed checks for "is registered and is not temporary", UserSelectQueryBuilder::named only checks for "is not a temporary account". This is a bug that should be fixed...

Change #1107951 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] UserSelectQueryBuilder: Do not consider unregistered actors to be named

https://gerrit.wikimedia.org/r/1107951

gerritbot added a project: Patch-For-Review.Thu, Jan 2, 2:49 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.Thu, Jan 2, 2:49 PM

Change #1107951 merged by jenkins-bot:

[mediawiki/core@master] UserSelectQueryBuilder: Do not consider unregistered actors to be named

https://gerrit.wikimedia.org/r/1107951

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Thu, Jan 2, 5:07 PM

Urbanecm_WMF changed the subtype of this task from "Task" to "Bug Report".

Maintenance_bot removed a project: Patch-For-Review.Thu, Jan 2, 5:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Thu, Jan 2, 6:00 PM

Etonkovidova closed this task as Resolved.Thu, Jan 2, 9:40 PM

UserSelectQueryBuilder::named returns non-named usersClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

UserSelectQueryBuilder::named returns non-named users
Closed, ResolvedPublicBUG REPORT
Actions