chore: fix flow and tests

posva · posva · commit f597959b1488 · 2020-10-06T15:43:16.000+02:00
diff --git a/src/create-matcher.js b/src/create-matcher.js
@@ -180,7 +180,7 @@ function matchRoute (
     m = decodeURI(path).match(regex)
   } catch (err) {
     if (process.env.NODE_ENV !== 'production') {
-      warn(`Error decoding "${path}". Leaving it intact.`)
+      warn(false, `Error decoding "${path}". Leaving it intact.`)
     }
   }
 
diff --git a/src/util/query.js b/src/util/query.js
@@ -14,12 +14,12 @@ const encode = str =>
     .replace(encodeReserveRE, encodeReserveReplacer)
     .replace(commaRE, ',')
 
-export function decode (str) {
+export function decode (str: string) {
   try {
     return decodeURIComponent(str)
   } catch (err) {
     if (process.env.NODE_ENV !== 'production') {
-      warn(`Error decoding "${str}". Leaving it intact.`)
+      warn(false, `Error decoding "${str}". Leaving it intact.`)
     }
   }
   return str
diff --git a/test/e2e/specs/hash-mode.js b/test/e2e/specs/hash-mode.js
@@ -9,8 +9,8 @@ module.exports = {
     browser
       .url('http://localhost:8080/hash-mode/')
       .waitForElementVisible('#app', 1000)
-      .assert.count('li', 9)
-      .assert.count('li a', 8)
+      .assert.count('li', 12)
+      .assert.count('li a', 11)
       .assert.attributeContains('li:nth-child(1) a', 'href', '/hash-mode/#/')
       .assert.attributeContains('li:nth-child(2) a', 'href', '/hash-mode/#/foo')
       .assert.attributeContains('li:nth-child(3) a', 'href', '/hash-mode/#/bar')

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ function matchRoute (`
`180`	`180`	`m = decodeURI(path).match(regex)`
`181`	`181`	`} catch (err) {`
`182`	`182`	`if (process.env.NODE_ENV !== 'production') {`
`183`		- warn(`Error decoding "${path}". Leaving it intact.`)
	`183`	+ warn(false, `Error decoding "${path}". Leaving it intact.`)
`184`	`184`	`}`
`185`	`185`	`}`
`186`	`186`
Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,12 @@ const encode = str =>`
`14`	`14`	`.replace(encodeReserveRE, encodeReserveReplacer)`
`15`	`15`	`.replace(commaRE, ',')`
`16`	`16`
`17`		`-export function decode (str) {`
	`17`	`+export function decode (str: string) {`
`18`	`18`	`try {`
`19`	`19`	`return decodeURIComponent(str)`
`20`	`20`	`} catch (err) {`
`21`	`21`	`if (process.env.NODE_ENV !== 'production') {`
`22`		- warn(`Error decoding "${str}". Leaving it intact.`)
	`22`	+ warn(false, `Error decoding "${str}". Leaving it intact.`)
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`	`return str`