Content-Length: 199220 | pFad | https://github.com/AudioKit/Tonic/issues/30

20 shiftUp by an octave · Issue #30 · AudioKit/Tonic · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shiftUp by an octave #30

Closed
Ei9il opened this issue Feb 2, 2024 · 1 comment
Closed

shiftUp by an octave #30

Ei9il opened this issue Feb 2, 2024 · 1 comment

Comments

@Ei9il
Copy link

Ei9il commented Feb 2, 2024

Description

shiftUp only works with intervals but octave is not part of intervals

Proposed Solution

include octave in intervals

Describe Alternatives You've Considered

create additional function to shiftUpBySemitones(12)

Additional Context

No response
@aure aure closed this as completed in 71ac3dd Feb 23, 2024
@aure
Copy link
Member

aure commented Feb 23, 2024

I initially thought this was a silly case, but it was so easy to implement so I did so. But, thanks to that it exposed a bug in our Interval.betweenNotes function, so thank you for calling this to my attention. I'll probably also add diminished and augmented octaves now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aure @Ei9il








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/AudioKit/Tonic/issues/30

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy