Update WPA controller unittest to check new upscale-downscale metrics #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/add-metrics-test
branch
from
9028af4 to
89d4111
Compare
clamoriniere
force-pushed
the
clamoriniere/add-metrics-test
branch
from
89d4111 to
bc2f113
Compare
clamoriniere
force-pushed
the
clamoriniere/add-metrics-test
branch
from
bc2f113 to
02a554b
Compare
The commmit also modify the way the unit-tests valid the generated metrics that the controller emit when it does an action. Now the unit-tests will only validate the metric values that are provided inside the "wantPromMetrics" or each test.
clamoriniere
force-pushed
the
clamoriniere/add-metrics-test
branch
from
02a554b to
f23e504
Compare
L3n41c
approved these changes
Jul 10, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update WPA controller unit test to check new upscale-downscale metrics
The commit also modify the way the unit tests valid the generated metrics that the
controller emit when it does an action. Now the unit-tests will only validate
the metric values that are provided inside the "wantPromMetrics" or each test.
Motivation
Improve test coverage link to the PR #210
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.