Fix common folder not included in built wheel #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsornsen
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
This works, but __init__.py should be unnecessary for Python 3. However, it seems like it's a limitation for setuptools when using auto-discovery in setup.cfg. You could alternatively be more explicit here and remove the test.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add
__init__.pyfile tocommonfolder so it's found by setuptools when the wheel is being built.Type of Change
Check the type of change this PR addresses:
Backwards Compatibility
Documentation
Tests
Add a screenshot or paste your local test results below:
Misc
Thanks
Thank you for your interest and taking the time to contribute!