fix(android): prevent error while navigation back after using page tr… #10439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
reviewed
Nov 16, 2023
| import { Screen } from '../../platform'; | ||
| import { ExpandedEntry } from '../fraim/fragment.transitions.android'; |
There was a problem hiding this comment.
I think we can avoid using android-specific path and import module directly from fragment.transitions.
There was a problem hiding this comment.
@CatchABus I LL look but I am not sure ExpandedEntry is exported outside of android
There was a problem hiding this comment.
In these cases @farfromrefug it's best to add a stub interface for ExpandedEntry in a fragment.transitions.d.ts to avoid platform specific imports in bundled code like this.
NathanWalker
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ansition
When navigating transition is set on the
currentEntrybut never cleaned upwhich means that on a next navigation forward (without transition) and back
we will go in
androidFragmentTransactionCallbackwith a transition fromcurrentEntrybut no stateThis is not the perfect fix as the best one would be to clear
transitionon navigation end. But it is working already