feat(android): background color/image handling improvements #10451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
changed the title
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
|
CatchABus
force-pushed
the
android-background-improvements
branch
from
a8a9e6c to
9524783
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
|
CatchABus
force-pushed
the
android-background-improvements
branch
from
dba175a to
747753a
Compare
CatchABus
force-pushed
the
android-background-improvements
branch
from
db104bf to
b2c2d03
Compare
NathanWalker
changed the title
NathanWalker
changed the title
NathanWalker
approved these changes
Jun 28, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are cases when android native background is not unset when background or background color is set to null.
Also, blank shadow rules seem to cause weird behavior as there can be a view with
box-shadow: noneby default and that view will have its default drawable removed.Another thing that was tracked during tests is that cached drawable seems to be broken since ever because it's set to the wrong instance.
This is a continuation of #9615.
What is the new behavior?
This patch takes care of the remaining background handling problems and adds a few android-specific helper functions to get rid of deprecated
setColorFiltercalls and duplicate code here and there.