Content-Length: 256560 | pFad | https://github.com/NativeScript/NativeScript/issues/10516

C70 fix(android): image tintColor setter by NathanWalker · Pull Request #10516 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): image tintColor setter #10516

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Apr 15, 2024

PR Checklist

What is the current behavior?

When using <Image [tintColor]="null" ... a throwable will occur:

java.lang.Throwable
Cannot read properties of null (reading 'android')
.[tintColor:setNative] (vendor.js)
.Style.<anonymous> (vendor.js)
.set tintColor [as tintColor] (vendor.js)
.ViewUtil.setPropertyInternal (vendor.js)
.ViewUtil.setProperty (vendor.js)
.EmulatedRenderer.setProperty (vendor.js)

What is the new behavior?

Image tintColor now handles null and undefined properly.

closes #10515

Sorry, something went wrong.

@cla-bot cla-bot bot added the cla: yes label Apr 15, 2024
@triniwiz triniwiz self-requested a review April 15, 2024 05:56
@NathanWalker NathanWalker merged commit 7e1cb19 into main Apr 15, 2024
3 of 4 checks passed
@NathanWalker NathanWalker deleted the fix/android-tint-color-setter branch April 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[android] Image tintColor set to null will cause a throwable
3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/issues/10516

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy