feat(ios): SF Symbol scale support via iosSymbolScale #10569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
commented
Jul 2, 2024
| if (typeof msg === 'string' && msg) { | ||
| args = msg; | ||
| if (options?.message) { | ||
| args = options.message; |
There was a problem hiding this comment.
Fixed build error here picked up by latest TS configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Could not set scale of symbol.
What is the new behavior?
Can now set the property
iosSymbolScalewith a value ofsmall | medium | large. This is important when using effects to ensure symbol does not exceed bounds which by default would use the Image container size.