Content-Length: 238999 | pFad | https://github.com/NativeScript/NativeScript/issues/10585

760 fix: targetSdk 34 registerBroadcastReceiver needs additional flags by edusperoni · Pull Request #10585 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: targetSdk 34 registerBroadcastReceiver needs additional flags #10585

Merged

NathanWalker merged 1 commit into main from fix/broadcast-receiver-flags

Jul 12, 2024

Contributor

edusperoni commented Jul 12, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

When targetting API 34, calling registerBroadcastReceiver throws an error due to https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported

What is the new behavior?

Error no longer thrown and we mark the broadcast as exported by default. The user can opt to make it not exported by passing the correct flag.


          fix: targetSdk 34 registerBroadcastReceiver needs additional flags

9e6fbcd

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 4c70596 into main

4 checks passed

NathanWalker deleted the fix/broadcast-receiver-flags branch

July 12, 2024 17:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels