Content-Length: 241556 | pFad | https://github.com/NativeScript/NativeScript/issues/10597

89F fix(android): Layout change listeners are ignored when using addEventListener by CatchABus · Pull Request #10597 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Layout change listeners are ignored when using addEventListener #10597

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:fix-layout-change-listener

Aug 5, 2024

Contributor

CatchABus commented Aug 4, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

In the case of android, layout change event listeners cannot be manipulated using addEventListener/removeEventListener.

What is the new behavior?

Layout change event listeners can be manipulated using addEventListener/removeEventListener.
Methods on and off call those internally.


          fix(android): Layout change listeners are ignored if added using addE…

da0c6ef

…ventListener

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into fix-layout-change-listener

072905b

NathanWalker merged commit 89fa6ec into NativeScript:main

1 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels