Content-Length: 240440 | pFad | https://github.com/NativeScript/NativeScript/issues/10609

75D fix: popover delegate should ignore non-native views by edusperoni · Pull Request #10609 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: popover delegate should ignore non-native views #10609

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

edusperoni
Copy link
Contributor

PR Checklist

What is the current behavior?

When opening a popover modal inside a "Proxy" view (like angular's ProxyViewContainer), the popover will fail to open with an error since the parent view has no native view.

What is the new behavior?

We now loop over parents until we find a valid view.

@NathanWalker NathanWalker merged commit ba3316e into main Aug 29, 2024
0 of 3 checks passed
@NathanWalker NathanWalker deleted the fix/popover-proxy-views branch August 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/issues/10609

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy