Content-Length: 267283 | pFad | https://github.com/NativeScript/NativeScript/issues/10627

75E fix(ios): replace depreciated UIApplication.shared.openUrl method call by jcassidyav · Pull Request #10627 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): replace depreciated UIApplication.shared.openUrl method call #10627

Merged

NathanWalker merged 1 commit into NativeScript:main from jcassidyav:fix-openurl

Oct 23, 2024

Contributor

jcassidyav commented Sep 20, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Calls to Utils.openUrl do not do anything if the app is compiled with XCode 16.

What is the new behavior?

UIApplication.shared.openUrl is depreciated, replaced with call to openURL:options:completionHandler


          fix(ios): openURL depreciated and does nothing from XCode 16 on.

039967a

NathanWalker approved these changes

View reviewed changes

paul-staskiewicz commented Oct 23, 2024

Will this go out anytime soon? We're in the process of upgrading to xcode16 and use openUrl quite often. Thank you!

NathanWalker merged commit 1cee35d into NativeScript:main

1 of 3 checks passed

edusperoni mentioned this pull request

feat: introduce openUrlAsync #10637

Merged

5 tasks

Contributor

NathanWalker commented Oct 23, 2024

@paul-staskiewicz included in 8.8.3

paul-staskiewicz commented Oct 23, 2024

@paul-staskiewicz included in 8.8.3

Already upgraded 😎 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet