ci: fix automated app CI workflow #10218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The CI action for the Automated app fails with a bunch of errors like these ones:
(example build: https://github.com/NativeScript/NativeScript/actions/runs/4204462364/jobs/7311437908)
What is the new behavior?
The workflow has been updated to use latest version of each action (bundled in here, but unrelated to the failing workflow).
We are setting the
install-links=false
flag to force linkingfile:
referenced packages.Background of the issue:
install-links
value to betrue
by defaultAbout the
install-links
flag from the NPM docs:So essentially, we were running
npm pack
inpackages/core
and then installing the pack intoapps/automated
, however this pack didn't contain neither the.ts
files (they are not part of the public package) nor.js
files, since we are not building core in this workflow - we instead rely on the source files (.ts
files) which are only included when we link the dependency instead of packing it.