Content-Length: 286592 | pFad | https://github.com/NativeScript/NativeScript/pull/10218

62 ci: fix automated app CI workflow by rigor789 · Pull Request #10218 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix automated app CI workflow #10218

Merged
merged 10 commits into from
Feb 18, 2023
Merged

ci: fix automated app CI workflow #10218

merged 10 commits into from
Feb 18, 2023

Conversation

rigor789
Copy link
Member

PR Checklist

What is the current behavior?

The CI action for the Automated app fails with a bunch of errors like these ones:

 ERROR in ./src/main.ts 8:0-69
Module not found: Error: Can't resolve '@nativescript/core' in '/Users/runner/work/NativeScript/NativeScript/apps/automated/src'

(example build: https://github.com/NativeScript/NativeScript/actions/runs/4204462364/jobs/7311437908)

What is the new behavior?

The workflow has been updated to use latest version of each action (bundled in here, but unrelated to the failing workflow).

We are setting the install-links=false flag to force linking file: referenced packages.


Background of the issue:

  • npm 9.0 changed install-links value to be true by default
  • GitHub Actions updated the macos environment from npm 8.9 to 9.3.1 recently

About the install-links flag from the NPM docs:

When set file: protocol dependencies will be packed and installed as regular dependencies instead of creating a symlink. This option has no effect on workspaces.

So essentially, we were running npm pack in packages/core and then installing the pack into apps/automated, however this pack didn't contain neither the .ts files (they are not part of the public package) nor .js files, since we are not building core in this workflow - we instead rely on the source files (.ts files) which are only included when we link the dependency instead of packing it.

Sorry, something went wrong.

@nx-cloud
Copy link

nx-cloud bot commented Feb 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ec28603. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Feb 18, 2023
@NathanWalker NathanWalker merged commit df7ecb9 into main Feb 18, 2023
@NathanWalker NathanWalker deleted the ci/automated-checks branch February 18, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10218

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy