Content-Length: 255159 | pFad | https://github.com/NativeScript/NativeScript/pull/10343

B1 fix(datepicker): max, min and date value binding handling by NathanWalker · Pull Request #10343 · NativeScript/NativeScript · GitHub

New issue

Jump to bottom

fix(datepicker): max, min and date value binding handling #10343

Merged

NathanWalker merged 2 commits into main from fix/datetimepicker-properties

Jul 17, 2023

Contributor

NathanWalker commented Jul 13, 2023 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

When using data bindings with date, minDate and maxDate crashes could occur with null/undefined values.

What is the new behavior?

These properties are now resilient to dynamic data binding conditions.

closes #8885


          fix(datepicker): max, min and date value binding handling

07453cf

cla-bot bot added the cla: yes label


          chore: cleanup

f40ac56

triniwiz approved these changes

View reviewed changes

Member

triniwiz left a comment

LGTM

NathanWalker merged commit 6effd55 into main

NathanWalker deleted the fix/datetimepicker-properties branch

July 17, 2023 19:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels