feat(css): support for text-overflow #10369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edusperoni
reviewed
Aug 27, 2023
| @@ -94,6 +94,14 @@ export namespace CoreTypes { | |||
| export const nowrap = 'nowrap'; | |||
| } | |||
|
|
|||
| export type TextOverflowType = 'clip' | 'ellipsis' | 'initial' | 'unset'; | |||
| export namespace TextOverflow { | |||
There was a problem hiding this comment.
I believe an enum or even just a const variable would e better than a namespace
There was a problem hiding this comment.
This just maintains the current consistency in core. Changing needs a more holistic core refactor.
edusperoni
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
text-overflowwas not supported. This means most buttons would truncate awkwardly like this by default:What is the new behavior?
Adds support for standard CSS
text-overflowto combine withwhite-spaceto achieve different truncation on text with labels and buttons. This allows you to settext-overflow: ellipsisto allow desired truncation:ref: NativeScript/tailwind#189
closes #5487