Content-Length: 240100 | pFad | https://github.com/NativeScript/NativeScript/pull/10575

EC #10573 (webpack) fix union type by insytes · Pull Request #10575 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10573 (webpack) fix union type #10575

Merged

NathanWalker merged 1 commit into NativeScript:main from insytes:main

Jul 6, 2024

Contributor

insytes commented Jul 5, 2024 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

TypeScript only recognises the function type of the single argument of mergeWebpack. The object type is ignored.

What is the new behavior?

Fixes the union type by parenthesising the function type.

Fixes #10573


          fix union type

3837fa6

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 0e2db6e into NativeScript:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels