Content-Length: 339253 | pFad | https://github.com/NativeScript/NativeScript/pull/10577

E1 feat(winter-cg): crypto, atob, btoa by triniwiz · Pull Request #10577 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(winter-cg): crypto, atob, btoa #10577

Merged
merged 15 commits into from
Jul 10, 2024
Merged

feat(winter-cg): crypto, atob, btoa #10577

merged 15 commits into from
Jul 10, 2024

Conversation

triniwiz
Copy link
Member

@triniwiz triniwiz commented Jul 9, 2024

No description provided.

@cla-bot cla-bot bot added the cla: yes label Jul 9, 2024
@farfromrefug
Copy link
Collaborator

@triniwiz Why making this part of Nativescript core while you added url into the runtime?
I personally, much prefer for it to be here but i quite dont understand why you switch. I would say everything should be in the same place.

Now it beeing here, wouldnt it be nicer to split that into a separated lib that widgets? while still importing it by default?
It would be cleaner, prevent widgets (and it is not widgets here) from becoming a bag of everything.
It would also easily allow splitting it into a separated "plugin" if need be (yes my fork would do that right away :P)

@NathanWalker
Copy link
Contributor

NathanWalker commented Jul 9, 2024

@farfromrefug With the new @nativescript/foundation package being planned out (to eventually supersede core in v10 likely), there will be separate modules. We'll provide more clarity on @nativescript/foundation planning before the end of the year in a detailed write-up and can discuss further in Discord group.

@NathanWalker NathanWalker marked this pull request as ready for review July 9, 2024 22:25
@NathanWalker NathanWalker added this to the 8.8 milestone Jul 9, 2024
@NathanWalker
Copy link
Contributor

NathanWalker commented Jul 10, 2024

Thanks again for the feedback @farfromrefug we split out a new @nativescript/winter-cg package:
51ebece
It will become a prebuilt for core (like widgets) in 8.8 initially but will become optional with the forthcoming @nativescript/foundation (see Discord).

Containing crypto, atob, btoa as Part 2 continuation towards full compliance.
@farfromrefug
Copy link
Collaborator

@NathanWalker awesome did not see that on discord. Will look

@NathanWalker NathanWalker merged commit f7679d7 into main Jul 10, 2024
1 of 4 checks passed
@NathanWalker NathanWalker deleted the feat/winter-cg-pt2 branch July 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10577

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy