Content-Length: 258368 | pFad | https://github.com/NativeScript/NativeScript/pull/10581

FD fix: re-add lowercase gesture handling and add deprecation notice when using non-string events by edusperoni · Pull Request #10581 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add lowercase gesture handling and add deprecation notice when using non-string events #10581

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: re-add lowercase gesture handling and add deprecation notice when using non-string events #10581

merged 1 commit into from
Jul 11, 2024

Conversation

edusperoni
Copy link
Contributor

makes gestures case-insensitive again for now

@cla-bot cla-bot bot added the cla: yes label Jul 11, 2024
@NathanWalker NathanWalker merged commit 6041b2d into main Jul 11, 2024
4 checks passed
@NathanWalker NathanWalker deleted the fix/gesture-event-deprecation branch July 11, 2024 02:05
SeanKelly369
SeanKelly369 reviewed Jul 11, 2024
View reviewed changes
Copy link

@SeanKelly369 SeanKelly369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed. Otherwise existing code using GestureTypes.tap, .doubleTap etc will need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanKelly369 SeanKelly369 SeanKelly369 left review comments

@NathanWalker NathanWalker NathanWalker approved these changes

@nick0704350 nick0704350 nick0704350 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edusperoni @NathanWalker @SeanKelly369 @nick0704350








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10581

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy