Content-Length: 262932 | pFad | https://github.com/NativeScript/NativeScript/pull/10656

96 feat(core): Added support for simultaneous pseudo states by CatchABus · Pull Request #10656 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Added support for simultaneous pseudo states #10656

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Nov 25, 2024

PR Checklist

What is the current behavior?

Right now, there are cases when views lose some of their visual states because only a single visual state is supported at a time.

What is the new behavior?

This PR ensures that a view may own multiple visual/pseudo states at the same time.
Added _addVisualState and _removeVisualState private methods and deprecated _goToVisualState private method to achieve this.
New methods will internally add/remove defaultVisualState when needed.
On top of that, existing event listeners were improved and added automated tests for new methods as well.

These changes were inspired from #9789 even though they have not included any new public API for modifying view pseudo-states so let's leave the issue open.

@NathanWalker NathanWalker merged commit f970455 into NativeScript:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10656

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy