fix(ios): Corrected rotate animation execution #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
approved these changes
Jan 25, 2025
NathanWalker
force-pushed
the
fix/ios-rotate-animation
branch
from
5d1b782 to
ff194b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, core iOS animations do not consider rotate as an affine transform causing some features like spring animation to break.
This became apparent once I took a small look in @farfromrefug's #9892 (thanks 🙏 ) and noticed that some rotation logic was missing.
What is the new behavior?
iOS will animate rotations the right way. Also, it fixes the broken spring case.