Content-Length: 274819 | pFad | https://github.com/NativeScript/NativeScript/pull/10685

B1 ref(core): Style properties module improvements and organization by CatchABus · Pull Request #10685 · NativeScript/NativeScript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Style properties module improvements and organization #10685

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the new behavior?

This PR performs some refactoring on the style-properties module.
More specifically:

  • Added new FixedLengthType type. It's only used for translate css properties but can cover more needs in the future
  • Corrected a few transform types in animation module
  • Added ClipPathFunction class. This class will keep data related to clip-path shape functions
  • Moved all transform-related functions from style-properties to a new css-transform module
  • Removed any type casts and improved types in css-transform module
  • Moved all style-properties functions to the top
  • Removed duplicate code used for calculating shorthand css properties
  • Added value converter and equality comparer for clip-path property

@CatchABus CatchABus marked this pull request as ready for review February 2, 2025 16:15
@CatchABus CatchABus force-pushed the ref/style-properties branch from 419404e to 62b4a26 Compare February 2, 2025 16:16
@NathanWalker NathanWalker merged commit 3a7206f into NativeScript:main Feb 4, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/NativeScript/pull/10685

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy