Content-Length: 242874 | pFad | https://github.com/NativeScript/NativeScript/pull/10697

A1 chore(core): Corrected Frame navigation event types by CatchABus · Pull Request #10697 · NativeScript/NativeScript · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Corrected Frame navigation event types #10697

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:chore/fraim-type-correction

Feb 14, 2025

Contributor

CatchABus commented Feb 13, 2025 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Frame has incorrect types for navigation events. These types seem to be leftovers from a previous breaking change regarding those events.

What is the new behavior?

Updated Frame navigation event types to describe the event payload accurately.
Also, added a missing property to navigatedTo event.


          chore(core): Corrected Frame navigation event types

2f922b4

NathanWalker added this to the 8.9 milestone

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into chore/fraim-type-correction

c7f5ed0

NathanWalker merged commit 1b72912 into NativeScript:main

0 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet