Plamen5kov/remove obsolete code #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored create project functionality removed --copy-from option, removed --tns-modules-version removed --copy-from and --link-to options prepare template now expects template name will never be undefined
rosen-vladimirov
approved these changes
Jan 31, 2017
lib/npm-installation-manager.ts
Outdated
| @@ -27,7 +27,7 @@ export class NpmInstallationManager implements INpmInstallationManager { | |||
| let cliVersionRange = `~${this.$staticConfig.version}`; | |||
| let latestVersion = await this.getLatestVersion(packageName); | |||
| if (semver.satisfies(latestVersion, cliVersionRange)) { | |||
| return latestVersion; | |||
| return Promise.resolve(latestVersion); | |||
There was a problem hiding this comment.
Why is this changed? When you mark method with async keyword, the returned value is always wrapped in Promise.
There was a problem hiding this comment.
didn't know that, will revert it to previous state
lib/services/project-service.ts
Outdated
| } | ||
| let templatePath = await this.$projectTemplatesService.prepareTemplate(selectedTemplate, projectDir); |
There was a problem hiding this comment.
I believe all of these operations should be in the try-catch block below.
|
👍 We will fix the test when the PR is merged in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping: @rosen-vladimirov
_EDIT: Related to: #2362 #2357