Update the README with older and more useful version #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
etabakov
commented
Apr 4, 2017
etabakov
commented
- OS X is replaced with macOS to match the current naming convention
- Installation instructions are replaced with a link to the documentation to avoid duplication
- OS X is replaced with macOS to match the current naming convention - Installation instructions are replaced with a link to the documentation to avoid duplication
yyosifov
approved these changes
Apr 4, 2017
yyosifov
reviewed
Apr 4, 2017
|
|
||
| [Back to Top][1] | ||
|
|
||
| ## Emulate Your Project |
There was a problem hiding this comment.
We can improve this later - the emulate command is obsolete/removed now I think
There was a problem hiding this comment.
My bad, I removed some references to emulate, but missed this one.
rosen-vladimirov
suggested changes
Apr 4, 2017
README.md
Outdated
| To learn how to contribute to the code base, click [here](https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base). | ||
|
|
||
| [Back to Top][1] | ||
| How to Build |
There was a problem hiding this comment.
you need new line before How to Build
README.md
Outdated
| To use the locally built CLI instead `tns` you can call `PATH_TO_CLI_FOLDER/bin/tns`. For example: | ||
| `PATH_TO_CLI_FOLDER/bin/tns run ios|android` | ||
|
|
||
| > NOTE: You should have [SSH key set](https://github.com/settings/keys) for your Git in order add the submodule via [smart git protocol](https://github.com/settings/keys). |
There was a problem hiding this comment.
we do not have this requirement anymore because the submodule is referenced via https instead of ssh
rosen-vladimirov
approved these changes
Apr 4, 2017
|
This is my favorite PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.