Content-Length: 257646 | pFad | https://github.com/NativeScript/nativescript-cli/pull/5517

C0 feat: default template version based on cli major by janoshrubos · Pull Request #5517 · NativeScript/nativescript-cli · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default template version based on cli major #5517

Merged

Conversation

janoshrubos
Copy link
Contributor

PR Checklist

What is the current behavior?

What is the new behavior?

ns create will use the same template major version as the CLI.

Fixes #5515.

@cla-bot cla-bot bot added the cla: yes label Apr 12, 2021
Copy link
Contributor

@NathanaelA NathanaelA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM.

@NathanaelA

This comment was marked as abuse.

@rigor789
Copy link
Member

@NathanaelA we were just wondering if it's worth backporting, since either way requires a CLI update. The ns8 CLI should be backwards compatible with 6.5.x+ projects, so for most people it's recommended to update and use latest - and for those who want to create an older project, the explicit version has to be passed when creating (@^7.0.0 for example).

@rigor789 rigor789 merged commit 2f1d876 into NativeScript:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TNS7 CLI pulls TNS 8 Templates, causing broken builds
3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/nativescript-cli/pull/5517

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy