Content-Length: 258342 | pFad | https://github.com/NativeScript/nativescript-cli/pull/5820

D4 fix: apple authentication, appstore list, publish by jcassidyav · Pull Request #5820 · NativeScript/nativescript-cli · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apple authentication, appstore list, publish #5820

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

jcassidyav
Copy link
Contributor

PR Checklist

What is the current behavior?

Any operation in the CLI which requires an authentication to apple fails with a 401.

What is the new behavior?

Apple authentication changed to a srp implementation, which resulted in the exiting code breaking with an error of 401 on anything that required authentication.

This PR uses a SRP implementation to perform the authentication in the apple way (it is not standard SRP) it consumes a new dependency (@foxt/js-srp) which performs the SRP calculations.

In addition to the authentication, this PR also Fixes:

  • ns appstore list a further change in the apple api was causing this to fail.
  • ns publish when providing a profile, changed it to use the buildForAppStore flag which results in the correct behaviour, also adding signingStyle manual to the export plist.
  • ns publish without specifying a profile. Added -allowProvisioningUpdates to the export archive command when no profiles were specified.
  • Replaced the depreciated app-store with app-store-connect method in distribution plist. ( which requires xcode > 14.3 but 15 needed now to publish anyway)

Fixes/Implements/Closes #5818.

@NathanWalker
Copy link
Contributor

Excellent work @jcassidyav ❤️

@NathanWalker NathanWalker added this to the 8.9 milestone Nov 4, 2024
@NathanWalker NathanWalker changed the title fix: Apple authentication, appstore list, publish fix: apple authentication, appstore list, publish Nov 4, 2024
@NathanWalker NathanWalker merged commit 5e381d4 into NativeScript:main Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error for ios - status code 401
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/NativeScript/nativescript-cli/pull/5820

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy