Content-Length: 259305 | pFad | https://github.com/Nike-Inc/spark-expectations/pull/59

0A Update CONTRIBUTORS.md - for PR #57 by BharatKumarEY · Pull Request #59 · Nike-Inc/spark-expectations · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTORS.md - for PR #57 #59

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

BharatKumarEY
Copy link
Contributor

@BharatKumarEY BharatKumarEY commented Nov 29, 2023

Update in contributors file for the approved PR #57

Description

Adding the name in the contributors list

Related Issue

Please link to the issue here: #56

Motivation and Context

Feature is already merged, context of this PR is to just add the name into contributors.md file

How Has This Been Tested?

Testing documents already submitted in PR #57 - This is just for adding name into contributors list

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d546bb) 100.00% compared to head (994e143) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1441      1441           
=========================================
  Hits          1441      1441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@asingamaneni asingamaneni merged commit 5e6c601 into Nike-Inc:main Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/Nike-Inc/spark-expectations/pull/59

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy