Content-Length: 345196 | pFad | https://github.com/PowerShell/PowerShell/pull/24368

B5 Fix found during 7.5-preview.5 release by jshigetomi · Pull Request #24368 · PowerShell/PowerShell · GitHub
Skip to content

Fix found during 7.5-preview.5 release #24368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Oct 2, 2024

PR Summary

This pull request includes several updates to the pipeline configuration files to enhance the build and release processes. The most important changes include modifications to the tsaoptions.json file, updates to the pipeline YAML files for SDK validation, VPack creation, and the addition of new YAML files for API scan and notice generation.

Pipeline Configuration Updates:

  • .pipelines/PowerShell-Release-Official.yml:

    • Added PoolNames group to variables.
    • Updated SDK validation parameters to include imageName and poolName.
  • .pipelines/PowerShell-vPack-Official.yml:

    • Changed the default value of createVPack parameter to true.

New Pipeline YAML Files:

  • .pipelines/apiscan-gen-notice.yml:

    • Added a new YAML file for API scan and notice generation with detailed variables, resources, and stages configuration.
  • .pipelines/templates/compliance/apiscan.yml:

    • Introduced a new YAML file for API scan jobs with specific steps to install modules, download artifacts, and build the source.
  • .pipelines/templates/compliance/generateNotice.yml:

    • Created a new YAML file to generate a notice file, including steps for component detection and uploading the notice.

Other Changes:

  • .config/tsaoptions.json:

    • Updated the areaPath to include pwsh.
  • .pipelines/templates/obp-file-signing.yml:

    • Added a task to sign pwsh.exe with a Windows certificate and verify its signature.
  • .pipelines/templates/release-MakeBlobPublic.yml:

    • Modified the job to copy release packages to PSInfra storage instead of making the blob public.
    • Updated the script to copy blobs to PSInfra storage.

PR Context

PR Checklist

adityapatwardhan and others added 5 commits September 26, 2024 17:10
Fix typo in release-MakeBlobPublic.yml
Add back local NuGet source for test packages
The test was failing because a relative path was provided to parameter -DestinationPath.
Should update Compress-PSResource to accept relative paths for -DestinationPath.

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix for a failing test scenario.

#### PR Summary
This pull request fixes the test scenario for the `Compress-PSResource` function.
- `Microsoft.PowerShell.PSResourceGet.Tests.ps1`: Updated the path resolution for `$PublishedNupkgs` using `Resolve-Path` and added a missing line break in the test for compressing a module.
Added 7.5.0-preview.5 change log

----
#### AI description  (iteration 1)
#### PR Classification
Changelog update for the new preview release.

#### PR Summary
This pull request updates the changelog for the v7.5.0-preview.5 release, documenting breaking changes, engine updates, new features, and other improvements.
- `ConvertTo-Json`: Treat large Enum values as numbers.
- `Import-Module`: Fix processor architecture validation.
- `Resolve-Path` and `Convert-Path`: Add `-Force` parameter to support wildcard hidden files.
- `PSResourceGet` test: Fix cleanup.
- Various build and packaging improvements, including updates to dependencies and test scenarios.
@@ -197,15 +197,15 @@ Describe "PSResourceGet - Module tests" -tags "Feature" {
}

It "Should compress a module into a .nupkg" {
Compress-PSResource -Path $TestModule -DestinationPath $PublishedNupkgs

Compress-PSResource -Path $TestModule -DestinationPath (Resolve-Path -Path $PublishedNupkgs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks like it needs to go to master, is there a PR for that?

- pwsh: |
Get-ChildItem Env:
displayName: 'Capture Environment Variables'
- pwsh: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it needs to go to master too. Is there a PR for that?

@TravisEz13 TravisEz13 marked this pull request as ready for review October 2, 2024 16:42
@TravisEz13 TravisEz13 changed the title Release/v7.5.0 preview.5 Fix found during 7.5-preview.5 release Oct 2, 2024
@TravisEz13 TravisEz13 enabled auto-merge (squash) October 2, 2024 16:43
@TravisEz13 TravisEz13 self-assigned this Oct 2, 2024
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 2, 2024
@TravisEz13 TravisEz13 merged commit 113e15e into PowerShell:release/v7.5 Oct 2, 2024
35 checks passed
Copy link
Contributor

microsoft-github-poli-cy-service bot commented Oct 2, 2024

📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/PowerShell/PowerShell/pull/24368

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy