-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix found during 7.5-preview.5 release #24368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix found during 7.5-preview.5 release #24368
Conversation
Fix typo in release-MakeBlobPublic.yml
Add back local NuGet source for test packages
The test was failing because a relative path was provided to parameter -DestinationPath. Should update Compress-PSResource to accept relative paths for -DestinationPath. ---- #### AI description (iteration 1) #### PR Classification Bug fix for a failing test scenario. #### PR Summary This pull request fixes the test scenario for the `Compress-PSResource` function. - `Microsoft.PowerShell.PSResourceGet.Tests.ps1`: Updated the path resolution for `$PublishedNupkgs` using `Resolve-Path` and added a missing line break in the test for compressing a module.
Added 7.5.0-preview.5 change log ---- #### AI description (iteration 1) #### PR Classification Changelog update for the new preview release. #### PR Summary This pull request updates the changelog for the v7.5.0-preview.5 release, documenting breaking changes, engine updates, new features, and other improvements. - `ConvertTo-Json`: Treat large Enum values as numbers. - `Import-Module`: Fix processor architecture validation. - `Resolve-Path` and `Convert-Path`: Add `-Force` parameter to support wildcard hidden files. - `PSResourceGet` test: Fix cleanup. - Various build and packaging improvements, including updates to dependencies and test scenarios.
@@ -197,15 +197,15 @@ Describe "PSResourceGet - Module tests" -tags "Feature" { | |||
} | |||
|
|||
It "Should compress a module into a .nupkg" { | |||
Compress-PSResource -Path $TestModule -DestinationPath $PublishedNupkgs | |||
|
|||
Compress-PSResource -Path $TestModule -DestinationPath (Resolve-Path -Path $PublishedNupkgs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks like it needs to go to master, is there a PR for that?
- pwsh: | | ||
Get-ChildItem Env: | ||
displayName: 'Capture Environment Variables' | ||
- pwsh: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it needs to go to master too. Is there a PR for that?
📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
This pull request includes several updates to the pipeline configuration files to enhance the build and release processes. The most important changes include modifications to the
tsaoptions.json
file, updates to the pipeline YAML files for SDK validation, VPack creation, and the addition of new YAML files for API scan and notice generation.Pipeline Configuration Updates:
.pipelines/PowerShell-Release-Official.yml
:PoolNames
group to variables.imageName
andpoolName
..pipelines/PowerShell-vPack-Official.yml
:createVPack
parameter totrue
.New Pipeline YAML Files:
.pipelines/apiscan-gen-notice.yml
:.pipelines/templates/compliance/apiscan.yml
:.pipelines/templates/compliance/generateNotice.yml
:Other Changes:
.config/tsaoptions.json
:areaPath
to includepwsh
..pipelines/templates/obp-file-signing.yml
:pwsh.exe
with a Windows certificate and verify its signature..pipelines/templates/release-MakeBlobPublic.yml
:PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).