-
Notifications
You must be signed in to change notification settings - Fork 21
Adds Jedis constructor, general cleanup #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gkorland
merged 14 commits into
RedisGraph:master
from
bsbodden:bsb/clean_up_and_jedis_constructor
Jan 10, 2022
Merged
Adds Jedis constructor, general cleanup #135
gkorland
merged 14 commits into
RedisGraph:master
from
bsbodden:bsb/clean_up_and_jedis_constructor
Jan 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsbodden
commented
Nov 14, 2021
- Adds Jedis instance constructor + tests
- Removes all unused imports
- Fixed all deprecation warning
- Updates JUnit 4 to latest release
sazzad16
suggested changes
Jan 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the tab characters with spaces.
sazzad16
suggested changes
Jan 8, 2022
src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphException.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphException.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphException.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redislabs/redisgraph/exceptions/JRedisGraphErrorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redislabs/redisgraph/exceptions/JRedisGraphErrorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redislabs/redisgraph/exceptions/JRedisGraphErrorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redislabs/redisgraph/exceptions/JRedisGraphErrorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redislabs/redisgraph/exceptions/JRedisGraphErrorTest.java
Outdated
Show resolved
Hide resolved
sazzad16
reviewed
Jan 8, 2022
src/main/java/com/redislabs/redisgraph/impl/api/RedisGraph.java
Outdated
Show resolved
Hide resolved
c91a8fb
to
a8fb210
Compare
Done. Thanks. |
a8fb210
to
9c46721
Compare
sazzad16
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.