Content-Length: 413306 | pFad | https://github.com/RocketChat/Rocket.Chat/pull/27241

EE test: sidebar ordination by name by jessicaschelly · Pull Request #27241 · RocketChat/Rocket.Chat · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: sidebar ordination by name #27241

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

test: sidebar ordination by name #27241

wants to merge 12 commits into from
+81 −0

Conversation

jessicaschelly
Copy link
Member

Proposed changes (including videos or screenshots)

This PR add tests for the feature "Sidebar ordination by name"

Issue(s)

Steps to test or reproduce

Further comments

@jessicaschelly jessicaschelly requested a review from a team as a code owner November 11, 2022 14:51
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ggazzo
✅ jessicaschelly
❌ Jessica

Jessica seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.54%. Comparing base (c4e58af) to head (b5b8c16).
Report is 942 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27241      +/-   ##
===========================================
- Coverage    55.05%   53.54%   -1.51%     
===========================================
  Files         2306     1087    -1219     
  Lines        50919    27127   -23792     
  Branches     10417     3784    -6633     
===========================================
- Hits         28033    14525   -13508     
+ Misses       20366    11868    -8498     
+ Partials      2520      734    -1786
Flag Coverage Δ
e2e-api ?
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly @ggazzo
Update apps/meteor/tests/e2e/page-objects/fragments/home-sidenav.ts
f67f20a 
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
@jessicaschelly jessicaschelly self-assigned this Nov 16, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 16, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Nov 17, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 17, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 17, 2022
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@ggazzo ggazzo changed the title Chore: End-to-end tests for the sidebar ordination by name test: sidebar ordination by name Apr 12, 2024
@jessicaschelly jessicaschelly requested a review from a team as a code owner April 12, 2024 17:15
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: b5b8c16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Apr 12, 2024
@jessicaschelly jessicaschelly marked this pull request as draft April 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janainaCoelhoRocketchat janainaCoelhoRocketchat janainaCoelhoRocketchat approved these changes

@gabriellsh gabriellsh Awaiting requested review from gabriellsh

@ggazzo ggazzo Awaiting requested review from ggazzo

At least 1 approving review is required to merge this pull request.

Assignees

@jessicaschelly jessicaschelly

Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessicaschelly @CLAassistant @ggazzo @janainaCoelhoRocketchat @sampaiodiego








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/RocketChat/Rocket.Chat/pull/27241

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy