Content-Length: 276544 | pFad | https://github.com/RustPython/RustPython/pull/5792

45 Remove unnecessary `uv run`in README by arihant2math · Pull Request #5792 · RustPython/RustPython · GitHub
Skip to content

Remove unnecessary uv runin README #5792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arihant2math
Copy link
Collaborator

Partial revert of #5771.
Two reasons for this:

  1. There is no tangible benefit to using uv here, the script has no dependencies.
  2. This breaks the run icons on the side of jetbrains editors for those don't use uv

/cc @rexledesma let me know if I've missed something

Remove unnecessary `uv run`
Copy link
Contributor

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv will ensure that the script is run on the correct version of Python. The script requires python>=3.13: https://github.com/RustPython/RustPython/blob/main/whats_left.py#L38-L44.

@youknowone
Copy link
Member

I am inclined to revert this change not to punish people who don't have uv.
The uv recommendation seems to be better to be placed in whats_left error who don't have default python 3.13
https://github.com/RustPython/RustPython/blob/main/whats_left.py#L43

@rexledesma
Copy link
Contributor

Editing the error message makes sense to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/RustPython/RustPython/pull/5792

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy