Avoid attribute protocol #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All this use of AttributeProtocol is using the internal interface rather than the proper vm attribute path. |
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 50.05% 52.91% +2.85%
==========================================
Files 81 81
Lines 15196 15564 +368
Branches 3661 3853 +192
==========================================
+ Hits 7607 8235 +628
+ Misses 5769 5485 -284
- Partials 1820 1844 +24
Continue to review full report at Codecov.
|
coolreader18
requested changes
Mar 21, 2019
cthulahoops
force-pushed
the
avoid_attribute_protocol
branch
from
0bef545 to
23ee751
Compare
|
Review comments addressed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of my big change (breaking it up a bit for review friendliness).