Content-Length: 260078 | pFad | https://github.com/SSilence/selfoss/pull/943

362 Make source code checkers accessible from Grunt by jtojnar · Pull Request #943 · fossar/selfoss · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source code checkers accessible from Grunt #943

Merged
merged 3 commits into from
Dec 6, 2017
Merged

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jun 9, 2017

No description provided.

@jtojnar jtojnar force-pushed the grunt-checkers branch 6 times, most recently from 6b29a1e to 252271e Compare June 15, 2017 16:05
@jtojnar
Copy link
Member Author

jtojnar commented Jun 19, 2017

I do not really like this. I asked on reddit and so far we have two alternatives:

@jtojnar jtojnar force-pushed the grunt-checkers branch 3 times, most recently from 92f6187 to 4ebbc06 Compare December 6, 2017 19:14
To make the development cycle faster we want developers to be able to run
all the required checks locally. Because of the way Composer is designed,
we cannot save the checkers as dev dependencies but have to install them
separately.

Instead of using composer for installing linters to utils directory, we
now use the tools from PATH, allowing users to install them using their
package manager of choice. For Travis and users running distributions
that do not have the checkers packaged, there is `utils/install-phars.sh`
helper script, which will install the necessary checkers to ~/.local/bin
directory.

This commit introduces new grunt tasks:

* `lint:server` will check PHP syntax using built-in PHP tool
* `cs:server` will check the coding style using PHP-CS-Fixer
* `check:server` will run both the checkers (more in the future)
* `check` will run both server side and client side checkers
@jtojnar
Copy link
Member Author

jtojnar commented Dec 6, 2017

In the end, I have decided to make users install the linters manually, either using a package manager or by calling utils/install-phars.sh.

@jtojnar jtojnar merged commit feef0a5 into master Dec 6, 2017
@jtojnar jtojnar deleted the grunt-checkers branch December 6, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/SSilence/selfoss/pull/943

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy