Content-Length: 341937 | pFad | https://github.com/TheAlgorithms/Go/pull/398

16 feat: Binary to Decimal Conversion by motasimmakki · Pull Request #398 · TheAlgorithms/Go · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Binary to Decimal Conversion #398

Merged
merged 7 commits into from
Oct 23, 2021
Merged

feat: Binary to Decimal Conversion #398

merged 7 commits into from
Oct 23, 2021

Conversation

motasimmakki
Copy link
Member

Description:

Algorithm to convert Binary number into its equivalent Decimal number.

tjgurwara99
tjgurwara99 requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the previous PR that you opened for decimal to binary I asked you to write the functions as convert and inverse (thinking that they were in their own package I made a mistake). Could you also correct those two functions. Rename Convert to DecimalToBinary and Inverse to Reverse in the strings package NOT in the convert package.

@motasimmakki
Copy link
Member Author

I just noticed that the previous PR that you opened for decimal to binary I asked you to write the functions as convert and inverse (thinking that they were in their own package I made a mistake). Could you also correct those two functions. Rename Convert to DecimalToBinary and Inverse to Reverse in the strings package NOT in the convert package.

Kindly have a look!

tjgurwara99
tjgurwara99 requested changes Oct 22, 2021
View reviewed changes
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the changes I have suggested. Apart from that everything looks fine to me 😄

@motasimmakki
Copy link
Member Author

Consider the changes I have suggested. Apart from that everything looks fine to me 😄

Sounds great, Kindly have a look! 🙃

@siriak siriak merged commit 18451c6 into TheAlgorithms:master Oct 23, 2021
@motasimmakki motasimmakki deleted the motasim branch October 23, 2021 11:38
@motasimmakki
Copy link
Member Author

@siriak
I request you to please invite me to join the organization on GitHub. 🎈

@siriak
Copy link
Member

siriak commented Oct 23, 2021

@motasimmakki why should we invite you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@siriak siriak Awaiting requested review from siriak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@motasimmakki @siriak @tjgurwara99 @raklaptudirm








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/TheAlgorithms/Go/pull/398

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy