feat: Godocmd action added for updating readme automatically. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgurwara99
requested review from
cclauss,
raklaptudirm and
siriak
as code owners
tjgurwara99
commented
Nov 4, 2021
tjgurwara99
commented
Nov 4, 2021
raklaptudirm
previously approved these changes
Nov 5, 2021
github-actions
bot
dismissed stale reviews from siriak and raklaptudirm
via
54bcd11
siriak
approved these changes
Nov 8, 2021
cclauss
reviewed
Nov 8, 2021
cclauss
approved these changes
Nov 8, 2021
|
So, should I merge it then? Might have to do manually as the golanci-lint action is stuck for some reason... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for taking long - was quite busy.
I have made a few changes to the workflows to better segregate them when multistep actions fail. Gives us more information as to where they fail etc.
I tried to make the godocmd fast but it still takes 7/8s because of all the additional sorting and changing a map to slice that it ended up like this 😓. But the result is still good I think.