add generics #528
Merged
add generics #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crunchypi
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
siriak
previously approved these changes
Aug 31, 2022
|
Haven't properly reviewed it - I glanced a bit and had some comments but didn't have time to completely review it. Will do that tonight 😄 |
tjgurwara99
requested changes
Aug 31, 2022
|
Heya, I’ve had a look at the suggestions — will think on it and reply later on today |
|
Alright, did the amending -- should cover the discussed things (+ changed the use of |
siriak
approved these changes
Sep 9, 2022
tjgurwara99
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added generic syntax for /structure/linkedlist; led to also having a need to change
some function signatures e.g
func (ll *Singly[T]) DelAtBeg() int // -1 on not-found
->
func (ll *Singly[T]) DelAtBeg() (T, bool)