style: handle edge cases uniformly in all implementations of factorial #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 86.65% 86.73% +0.08%
==========================================
Files 197 197
Lines 6519 6530 +11
==========================================
+ Hits 5649 5664 +15
+ Misses 730 727 -3
+ Partials 140 139 -1 ☔ View full report in Codecov by Sentry. |
vil02
force-pushed
the
make_factorial_uniform
branch
from
e4b49cd to
d210374
Compare
vil02
requested review from
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
tjgurwara99
reviewed
Feb 14, 2024
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
raklaptudirm
requested changes
Mar 17, 2024
Done in e9c894f. |
raklaptudirm
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementations of the factorial react differently for negative inputs. This PR fixes that. Furthermore it reduced the code duplication in the corresponding test file by expressing tests and benchmarks as parameterized.