Updated error messaging for Adyen/StripePI #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
reviewed
Jun 13, 2022
This changes the error message returned when the 'attempt_3dsecure' flag is left off a gateway request in need of authentication at the gateway to be clearer to someone using Spreedly's API. [ECS-2393](https://spreedly.atlassian.net/browse/ECS-2393) rake test:local - 5213 tests, 75896 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Stripe PI Unit: 39 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Stripe PI Remote: 77 tests, 357 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Adyen Unit: 94 tests, 479 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Adyen Remote (same 3 failures appear on Master): 123 tests, 439 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.561% passed
mbreenlyles
force-pushed
the
ECS-2393_clarify-error-message
branch
from
c57569e to
e4d299a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the error message returned when the 'attempt_3dsecure' flag is left off a gateway request in need of authentication at the gateway to be clearer to someone using Spreedly's API.
ECS-2393
rake test:local - 5213 tests, 75896 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Stripe PI Unit: 39 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Stripe PI Remote: 77 tests, 357 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Adyen Unit: 94 tests, 479 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Adyen Remote (same 3 failures appear on Master): 123 tests, 439 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.561% passed
Adyen remote failures also appear on the Master branch:
X test_failed_store_with_cabal_card (fails at failure response assertion, maybe they support recurring transactions with this card now?)
X test_successful_authorize_with_3ds2_browser_client_data (fails assert_equal response.params['resultCode'], 'IdentifyShopper' ---- with expected but was <"IdentifyShopper"> )
X test_successful_purchase_with_3ds2_exemption_requested_and_execute_threed_true (fails at assert_equal response.params['resultCode'], 'IdentifyShopper' ---- with expected but was <"IdentifyShopper"> )