Element/Vantiv: Add google pay and apple pay support #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherreraa
requested review from
Heavyblade,
sinourain,
Sainterman,
edgarv09 and
gasb150
Heavyblade
reviewed
Dec 14, 2022
There was a problem hiding this comment.
@jherreraa basically done, nice work !, leaved you a couple of comments.
jherreraa
force-pushed
the
SER-399-add_apple_google_pay_update
branch
from
7fd7f49 to
5f4dce2
Compare
jherreraa
force-pushed
the
SER-399-add_apple_google_pay_update
branch
from
5f4dce2 to
1557b30
Compare
naashton
requested changes
Dec 29, 2022
jherreraa
force-pushed
the
SER-399-add_apple_google_pay_update
branch
from
1557b30 to
a8e7459
Compare
naashton
approved these changes
Dec 30, 2022
jherreraa
force-pushed
the
SER-399-add_apple_google_pay_update
branch
from
a8e7459 to
e26ea8f
Compare
Heavyblade
approved these changes
Jan 3, 2023
| year: Time.new.year + 2, | ||
| source: :google_pay, | ||
| transaction_id: '123456789', | ||
| eci: '05') |
There was a problem hiding this comment.
❓ Question:
On docs I'm seeing that values to eci goes from 1 to 9, without the padding zero ('01', '02', etc), did you tried that on your tests ?
Summary: This PR updates element/vantiv gateway to support apple/google pay transactions Remote Tests Finished in 35.250506 seconds. 31 tests, 86 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 756 files inspected, no offenses detected
Heavyblade
force-pushed
the
SER-399-add_apple_google_pay_update
branch
from
e26ea8f to
96dbd6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates element/vantiv gateway to support apple/google pay transactions
Remote Tests
Finished in 35.250506 seconds.
31 tests, 86 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
756 files inspected, no offenses detected