Payeezy: Handle nil and empty values for Apple Pay #4694
Conversation
Payeezy support has indicated that passing empty or nil values in place of the `xid` and `cavv` may result in failed transactions for AMEX based AP tokens. They also informed us that the `eci_indicator` value should default to `5` instead of passing a nil value, following a similar pattern. This PR ignores empty `payment_cryptogram` and defaults the `eci_indicator` to `5` if that value is `nil`. Unit: 6 tests, 211 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 46 tests, 184 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
| nt_card[:xid] = payment_method.payment_cryptogram unless payment_method.payment_cryptogram.empty? | ||
| nt_card[:cavv] = payment_method.payment_cryptogram unless payment_method.payment_cryptogram.empty? |
There was a problem hiding this comment.
Do these need to be set to nil or omitted from being sent if there is no payment_cryptogram?
There was a problem hiding this comment.
Does this impact/benefit all customers of this gateway type (i.e.: is it an issue every customer faces presently) or just the one customer (Priceline?)
There was a problem hiding this comment.
We were explicitly told by Payeezy to NOT send nil values for these fields as they "could" lead to errors. These fields are optional according to Payeezy's documentation.
AFAIK, Priceline is the only user of AP on Payeezy, but this should not negatively impact any other customers of this gateway.
There was a problem hiding this comment.
@chudel this would benefit all customers of this gateway type
Payeezy support has indicated that passing empty or nil values in place of the
xidandcavvmay result in failed transactions for AMEX based AP tokens. They also informed us that theeci_indicatorvalue should default to5instead of passing a nil value, following a similar pattern.This PR ignores empty
payment_cryptogramand defaults theeci_indicatorto5if that value isnil.Unit: 6 tests, 211 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote: 46 tests, 184 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed