Add 3DS global support to Commerce Hub gateway #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Looks pretty much OK @sinourain, left a simple style comment
| @@ -109,6 +109,22 @@ def scrub(transcript) | |||
|
|
|||
| private | |||
|
|
|||
| def add_three_d_secure(post, payment, options) | |||
| params = post[:additionalData3DS] = {} | |||
There was a problem hiding this comment.
💬 Style/Comment:
Totally after you, but being more declarative than procedimental is always better:
def add_three_d_secure(post, payment, options)
return unless three_d_secure = options[:three_d_secure]
post[:additionalData3DS] = {
dsTransactionId: three_d_secure[:ds_transaction_id],
authenticationStatus: three_d_secure[:authentication_response_status],
serviceProviderTransactionId: three_d_secure[:three_ds_server_trans_id],
acsTransactionId: three_d_secure[:acs_transaction_id],
mpiData: {
cavv: three_d_secure[:cavv],
eci: three_d_secure[:eci],
xid: three_d_secure[:xid]
}.compact,
version data: { recommendedVersion: three_d_secure[:version] }
}.compact
end
sinourain
force-pushed
the
commercehub_add_3ds_support
branch
from
3fee156 to
393e3dd
Compare
------------------------- Add 3DS global support to Commerce Hub gateway Tickets for Spreedly reference SER-922 Unit test ------------------------- Finished in 23.891463 seconds. 5671 tests, 78366 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- 237.37 tests/s, 3280.08 assertions/s Rubocop ------------------------- 778 files inspected, no offenses detected
naashton
force-pushed
the
commercehub_add_3ds_support
branch
from
393e3dd to
f5dd610
Compare
naashton
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 3DS global support to Commerce Hub gateway
Tickets for Spreedly reference
SER-922
Unit test
Finished in 23.891463 seconds.
5671 tests, 78366 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote test
237.37 tests/s, 3280.08 assertions/s
Rubocop
778 files inspected, no offenses detected