Content-Length: 265518 | pFad | https://github.com/adafruit/circuitpython/pull/10134

19 Add missing PY_FUNCTION_ATTRS and PY_REVERSE_SPECIAL_METHODS by eightycc · Pull Request #10134 · adafruit/circuitpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing PY_FUNCTION_ATTRS and PY_REVERSE_SPECIAL_METHODS #10134

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

eightycc
Copy link
Collaborator

This PR resolves issue #10132. In addition to PY_FUNCTION_ATTRS it also adds PY_REVERSE_SPECIAL_METHODS which was similarly missing from several ports. The ports affected are:

  • broadcom
  • cxd56
  • espressif
  • litex
  • raspberrypi
  • renode

@eightycc eightycc linked an issue Mar 17, 2025 that may be closed by this pull request
@eightycc eightycc requested a review from tannewt March 18, 2025 00:18
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@dhalbert dhalbert merged commit b2752b3 into adafruit:main Mar 18, 2025
239 checks passed
@eightycc eightycc deleted the issue-10132 branch March 18, 2025 15:48
@dhalbert
Copy link
Collaborator

PY_REVERSE_SPECIAL_METHODS looks like it might have been already on for any board with ulab, which requires it. But doing it explicitly is a good idea so it will stay on even if ulab is turned off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn on MICROPY_PY_FUNCTION_ATTRS more consistently
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/adafruit/circuitpython/pull/10134

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy