Convert completely to new displayio bus bindings; remove warnings #10193
+1
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayio#10138This removes the ability to use the old displayio bus bindings, and also removes
CIRCUITPY_9_10_WARNINGSand the associated warnings.@tannewt It was my understanding it's OK to remove these warnings now, because they were meant to be present in 9.x.x (though we messed up on that a bit). If this is wrong, I can restore them.
There are no more uses of the old bindings in the library bundle.
Tested on a PyPortal Titano with the NASA image project.