fix(language-service): Update adapter to log instead of throw errors (#60651)

atscott · thePunderWoman · commit 0e9e0348dd97 · 2025-03-31T21:36:35.000Z
This prevents errors from being thrown from the adapters. Throwing errors in the language service causes the extension to crash. Repeated errors will permanently break the extension. fixes angular/vscode-ng-language-service#2166 PR Close #60651
diff --git a/packages/language-service/src/adapters.ts b/packages/language-service/src/adapters.ts
@@ -104,7 +104,8 @@ export class LanguageServiceAdapter implements NgCompilerAdapter {
    */
   readResource(fileName: string): string {
     if (isTypeScriptFile(fileName)) {
-      throw new Error(`readResource() should not be called on TS file: ${fileName}`);
+      console.error(`readResource() should not be called on TS file: ${fileName}`);
+      return '';
     }
     // Calling getScriptSnapshot() will actually create a ScriptInfo if it does
     // not exist! The same applies for getScriptVersion().
@@ -115,8 +116,9 @@ export class LanguageServiceAdapter implements NgCompilerAdapter {
     this.lastReadResourceVersion.set(fileName, version);
     const scriptInfo = this.project.getScriptInfo(fileName);
     if (!scriptInfo) {
-      // // This should not happen because it would have failed already at `getScriptVersion`.
-      throw new Error(`Failed to get script info when trying to read ${fileName}`);
+      // This should not happen because it would have failed already at `getScriptVersion`.
+      console.error(`Failed to get script info when trying to read ${fileName}`);
+      return '';
     }
     // Add external resources as root files to the project since we project language service
     // features for them (this is currently only the case for HTML files, but we could investigate
@@ -155,7 +157,8 @@ export class LSParseConfigHost implements ConfigurationHost {
   readFile(path: AbsoluteFsPath): string {
     const content = this.serverHost.readFile(path);
     if (content === undefined) {
-      throw new Error(`LanguageServiceFS#readFile called on unavailable file ${path}`);
+      console.error(`LanguageServiceFS#readFile called on unavailable file ${path}`);
+      return '';
     }
     return content;
   }
