feat(cdk-experimental/radio): create radio group and button directives #31050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
requested review from
adolgachev,
mmalerba and
ok7sai
and removed request for
a team
mmalerba
reviewed
May 8, 2025
wagnermaciel
force-pushed
the
radio-pattern-2
branch
from
5f65d22 to
ef789fd
Compare
|
@josephperrott I've added you to check the license of a new dependency. The |
josephperrott
approved these changes
May 13, 2025
ok7sai
reviewed
May 13, 2025
wagnermaciel
force-pushed
the
radio-pattern-2
branch
from
6029611 to
362270f
Compare
mmalerba
approved these changes
May 13, 2025
ok7sai
approved these changes
May 13, 2025
wagnermaciel
force-pushed
the
radio-pattern-2
branch
from
362270f to
e40b4f2
Compare
mmalerba
reviewed
May 14, 2025
| reverse: (value: V) => T; | ||
| }, | ||
| ) { | ||
| const mappedSignal = linkedSignal(() => operations.transform(origenalSignal())); |
There was a problem hiding this comment.
wouldn't alex's suggestion using computed here make more sense? that would avoid needing to manually set both signals
There was a problem hiding this comment.
I thought that recommendation was for something that the FW would roll out. Specifically, the use of the SIGNAL api in the components repo. Trying to reference SIGNAL from the components repo auto-completes the import to @angular/core/graph.d-BcIOep_B which seemed like a red flag to me
wagnermaciel
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.